-
Notifications
You must be signed in to change notification settings - Fork 1
Misc updates: fix typo, bump maven version, update gitignore #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fix typo in eclipse-cs.xml: "Checksyle" → "Checkstyle" - Bump mojo.maven.version from 3.8.1 to 3.9.0 - Add .claude/settings.local.json to .gitignore
📝 WalkthroughWalkthroughThis pull request applies three minor configuration updates: adding a local Claude settings file to Changes
Possibly related PRs
Poem
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @pom.xml:
- Line 27: Update and validate the Maven version bump (mojo.maven.version) by
auditing all plugins, custom Mojos, and build configs for Maven 3.9.0 breaking
changes: explicitly add plexus-utils as a dependency to any plugins that relied
on it, ensure no custom code bootstraps a RepositorySystem, validate
.mvn/maven.config uses one-argument-per-line, confirm the project/JDK toolchain
targets Java 8+ and update pom/enforcer rules if needed, test plugin behavior
under the new native HTTP transport and adjust plugin configs or versions for
compatibility, and run a full CI/integration build to catch new WARNINGs or
environment-dependent property issues before merging.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.gitignoreoss-build-support/src/main/resources/checkstyle/eclipse/eclipse-cs.xmlpom.xml
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: david-waltermire
Repo: metaschema-framework/metaschema-java PR: 618
File: core/src/main/java/dev/metaschema/core/datatype/package-info.java:52-52
Timestamp: 2026-01-05T18:03:33.537Z
Learning: In metaschema-framework/metaschema-java, CLAUDE.md is the canonical coding-guidelines document and now specifies dev.metaschema.* as the Java package convention (updated in PR #618).
📚 Learning: 2025-12-17T13:27:43.679Z
Learnt from: CR
Repo: metaschema-framework/metaschema-java PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-17T13:27:43.679Z
Learning: Use SpotBugs, PMD, Checkstyle, and Jacoco for static analysis. Project enforces Checkstyle code style, PMD source analysis (fails on priority 2+ violations), SpotBugs bug detection (with spotbugs-exclude.xml exclusions), and Jacoco code coverage (target: 60% coverage)
Applied to files:
pom.xml
📚 Learning: 2025-12-17T13:27:43.679Z
Learnt from: CR
Repo: metaschema-framework/metaschema-java PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-17T13:27:43.679Z
Learning: Applies to **/*.java : Java target version must be Java 11. Use SpotBugs annotations (NonNull, Nullable) for null safety in code.
Applied to files:
pom.xml
📚 Learning: 2026-01-05T18:03:33.537Z
Learnt from: david-waltermire
Repo: metaschema-framework/metaschema-java PR: 618
File: core/src/main/java/dev/metaschema/core/datatype/package-info.java:52-52
Timestamp: 2026-01-05T18:03:33.537Z
Learning: In metaschema-framework/metaschema-java, CLAUDE.md is the canonical coding-guidelines document and now specifies dev.metaschema.* as the Java package convention (updated in PR #618).
Applied to files:
.gitignore
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Website
🔇 Additional comments (2)
oss-build-support/src/main/resources/checkstyle/eclipse/eclipse-cs.xml (1)
3-3: LGTM - Typo correction.The profile name has been correctly updated from "SecAuto Checksyle" to "SecAuto Checkstyle".
.gitignore (1)
18-18: LGTM - Appropriate exclusion of local settings.Adding
.claude/settings.local.jsonto the gitignore is appropriate for keeping developer-specific local configurations out of version control.
Summary
Test plan
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.