152 delete temporary files in finalize - #153
Merged
Merged
Conversation
Contributor
Author
|
@ways CI is failing but looks like this happens because of issues with space |
Contributor
Investigating. |
Contributor
|
Should be OK now @havardhhaugen Runners comes with lots of included tools we don't use. I made sure some of them are removed before run. |
havardhhaugen
force-pushed
the
152-delete-temporary-files-in-finalize
branch
from
August 18, 2025 12:37
46fcadb to
9a0754b
Compare
Contributor
Author
|
@tnipen can you look through this when you have time? It's scary to merge functionality that deletes files. |
tnipen
reviewed
Aug 22, 2025
havardhhaugen
force-pushed
the
152-delete-temporary-files-in-finalize
branch
from
August 22, 2025 09:22
58b4dd6 to
c7a16d4
Compare
Member
|
Looks great now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #152
Default behavior is now to remove temporary files (and directory). Can be configured via a config key
remove_intermediate.