161 spatial metrics - #177
Merged
Merged
Conversation
Closed
Contributor
Author
|
Tests failing because pyshtools is missing from the test environment, I don't know where to fix that. |
Contributor
Added. |
ways
reviewed
Sep 12, 2025
ways
left a comment
Contributor
There was a problem hiding this comment.
No comments. I'd love a tox test (with config and necessary test data). For debugging, avoiding regressions and as example usage.
Contributor
Author
I made unit tests for the two new outputs, and I'll update the documentation once this has been merged. |
evenmn
reviewed
Sep 15, 2025
Contributor
Author
|
Good to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr implements a new output class Spatial, from which specific spatial outputs can subclass. The Spatial class is intended for outputs which do some sort of spatial operation, and it writes outputs as netcdf files with dimensions (time, leadtime, ensemble_member, *metric_specific_dimensions).
So far I have implemented two spatial outputs:
Example config
Introduces a new dependency pyshtools (used to calculate spherical harmonics fourier transform)