Push to both ACR and GHCR. - #8
Conversation
| env: | ||
| IMAGE: fortiregistry.azurecr.io/${{ matrix.service }}:${{ github.run_id }} | ||
| ACR_IMAGE: fortiregistry.azurecr.io/${{ matrix.service }}:${{ github.run_id }} | ||
| GHCR_IMAGE: ghcr.io/${{ github.repository_owner }}/${{ matrix.service }}:${{ github.run_id }} |
There was a problem hiding this comment.
Maybe qualify the name more? Now, GHCR_IMAGE expands to something like ghcr.io/metno/xmlfrontend:SOME_ID. I think that adding a "forti" here somewhere is needed. For example make something like this: ghcr.io/metno/forti-xmlfrontend:SOME_ID
There was a problem hiding this comment.
Agreed. Should we rename the acr images as well? For sake of consistency?
There was a problem hiding this comment.
Renaming acr images would require changes in deployments. I believe we should keep those as is for now. But at some point we should probably rethink the build strategy, and use tags instead of build numbers.
| env: | ||
| IMAGE: fortiregistry.azurecr.io/fortiup:${{ github.run_id }} | ||
| ACR_IMAGE: fortiregistry.azurecr.io/fortiup:${{ github.run_id }} | ||
| GHCR_IMAGE: ghcr.io/${{ github.repository_owner }}/fortiup:${{ github.run_id }} |
There was a problem hiding this comment.
maybe skip pushing this one to ghcr for now? It is not really needed as a docker container for others.
| runs-on: ubuntu-latest | ||
| env: | ||
| ACR_IMAGE: fortiregistry.azurecr.io/devcontainer:latest | ||
| GHCR_IMAGE: ghcr.io/${{ github.repository_owner }}/devcontainer:latest |
There was a problem hiding this comment.
again, maybe forti-devcontainer?
2 participants
No description provided.