Skip to content

reduces var to only unique, returns totnum in _len_datapoints - #1788

Open
dulte wants to merge 1 commit into
main-devfrom
filterfix
Open

reduces var to only unique, returns totnum in _len_datapoints#1788
dulte wants to merge 1 commit into
main-devfrom
filterfix

Conversation

@dulte

@dulte dulte commented Feb 17, 2026

Copy link
Copy Markdown
Collaborator

Change Summary

Something made the earlinet eval super slow. Some debugging lead me to ungriddeddata._len_datapoints.

  1. the var list has many thousands of copies of the same var. I guess this is an error? Made it so var = list(set(var)). The resulting totnum is drastically different
  2. totnum was not actually returned

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@codecov

codecov Bot commented Feb 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.49%. Comparing base (2abd82e) to head (f871ce6).
⚠️ Report is 149 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1788      +/-   ##
============================================
+ Coverage     78.36%   78.49%   +0.12%     
============================================
  Files           176      176              
  Lines         23414    23446      +32     
============================================
+ Hits          18349    18404      +55     
+ Misses         5065     5042      -23     
Flag Coverage Δ
unittests 78.49% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dulte dulte self-assigned this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant