Skip to content

Qc first changes - #288

Merged
jjordene merged 15 commits into
mainfrom
QC-first-changes
Sep 7, 2026
Merged

Qc first changes#288
jjordene merged 15 commits into
mainfrom
QC-first-changes

Conversation

@jjordene

@jjordene jjordene commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Sourceterm file export
Meteo override for QC cases in snap4rimsterm
Changes era5 required variables to accumulated sensible heat flux and surface stress

@jjordene
jjordene requested a review from heikoklein September 2, 2026 09:32
Comment thread src/common/snapdebugML.F90 Outdated
Comment thread src/common/release.f90 Outdated
Comment thread src/common/release.f90 Outdated
Comment thread src/common/snapmetML.f90
Comment thread utils/SnapPy/snap4rimsterm
@jjordene
jjordene requested a review from heikoklein September 2, 2026 11:32
Comment thread src/common/snapdebugML.F90 Outdated
integer, public, save :: idebug = 0
!> output unit for log file
integer, public :: iulog
!> output unit for sourceterm file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to release.f, this does not really belong to debugging and is more connected to the release, and it is used only in release.f and snap.F90

@heikoklein
heikoklein self-requested a review September 2, 2026 12:32
Comment thread src/common/release.f90 Outdated
Comment thread src/common/release.f90 Outdated
Comment thread src/common/release.f90 Outdated
@jjordene
jjordene requested a review from heikoklein September 7, 2026 12:55

@heikoklein heikoklein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@jjordene
jjordene merged commit b4a60e6 into main Sep 7, 2026
4 checks passed
@jjordene
jjordene deleted the QC-first-changes branch September 7, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants