fix: close dropdown for keyboard navigation #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
force-pushed
the
metonym/fix-blur
branch
from
5d32e93 to
7c83b16
Compare
metonym
force-pushed
the
metonym/fix-blur
branch
from
7c83b16 to
47257c4
Compare
metonym
changed the title
Owner
Author
|
Fixed in v5.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95
This fixes the dropdown not closing when input loses focus via keyboard navigation. This causes overlapping dropdowns and renders the page unusable when
showAllResultsOnFocusis enabled.Changes
clicktomousedownwithpreventDefault()to prevent the input from losing focus when clicking results. This ensures the blur handler only fires for legitimate focus loss (e.g., tab navigation) rather than result selection.