Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explain :path of ref schemas #1158

Merged
merged 2 commits into from
Feb 16, 2025
Merged

fix: explain :path of ref schemas #1158

merged 2 commits into from
Feb 16, 2025

Conversation

opqdonut
Copy link
Member

@opqdonut opqdonut commented Jan 8, 2025

The path from a [:ref ::kw] or a [:ref #'Var] to the referred schema
is [0 0] due to the intermediate -pointer. See additions to
get-in-test. Thus the -explainer of a -ref-schema needs to add [0 0]
to the path, instead of the previous [0]. This mirrors the [0 0]
already present in the -walk of -ref-schema.

fixes #1106

The path from a [:ref ::kw] or a [:ref #'Var] to the referred schema
is [0 0] due to the intermediate -pointer. See additions to
get-in-test. Thus the -explainer of a -ref-schema needs to add [0 0]
to the path, instead of the previous [0]. This mirrors the [0 0]
already present in the -walk of -ref-schema.

fixes #1106
@opqdonut opqdonut requested a review from ikitommi January 8, 2025 09:18
@ikitommi
Copy link
Member

👍

@ikitommi ikitommi merged commit 28d72f4 into master Feb 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-ref-schema returns wrong path in -explainer when the ref is a var
2 participants