Skip to content

updated with peer - #116

Open
raghavdhingra wants to merge 2 commits into
major_refactorfrom
peer
Open

updated with peer#116
raghavdhingra wants to merge 2 commits into
major_refactorfrom
peer

Conversation

@raghavdhingra

Copy link
Copy Markdown
Member

No description provided.

@raghavdhingra raghavdhingra added the enhancement New feature or request label Jul 11, 2021
@raghavdhingra raghavdhingra self-assigned this Jul 11, 2021
@netlify

netlify Bot commented Jul 11, 2021

Copy link
Copy Markdown

❌ Deploy Preview for inc0g failed.

🔨 Explore the source changes: 1e75dfa

🔍 Inspect the deploy log: https://app.netlify.com/sites/inc0g/deploys/60eadff09227fc0007a8ae04

// eslint-disable-next-line
}, [isAskForUsername, isVideoActive, isAudioActive]);

function addVideoStream(video, stream) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this to fat arrow or convert others to function syntax

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 11, 2021

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e75dfa
Status: ✅  Deploy successful!
Preview URL: https://8e69d8d0.incogly.pages.dev

View logs

@sansyrox sansyrox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

Please see inline comments.

<div className="home_page__container">
<NavBar />
<Container>
<div className="container">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this bem compliant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants