Update rails#231
Open
do-you-dare wants to merge 32 commits intomasterfrom
Open
Conversation
Member
|
What do you think about removing Travis' build for those older breaking version? |
Member
|
What is the status on WIP acceptance test? |
Author
|
Sorry, for a moment I forgot I wip-ed them. So, only one of them is passing. The |
added 26 commits
December 1, 2016 21:01
This gem eases the job of upgrading the application gems.
It required activesupport ~>4.2, while rails 5 requires 5.0.0.1.
The changes on Rails break some of the code, and the tests with them, that's why they are pending.
added 6 commits
December 1, 2016 21:10
As of rails 5, Active Record Models inherit from ApplicationRecord by default.
The rails 5 update task overwrites the routes configuration.
As of Rails 5, jobs inherit from ApplicationJob, not ActiveJob::Base.
Activesupport doesn't support rubies 2.2 and 2.1.5, and it makes no sense to test against something we know that won't and shouldn't pass.
do-you-dare
force-pushed
the
update_rails
branch
from
1ce7a60 to
2b6a8a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates rails to Rails 5. The ci checks will fail for rubies 2.0 and 2.1.5, since rails doesn't support them anymore.