Generic exception message to catch-all exception#97
Open
pinclau wants to merge 2 commits intomezzio:3.0.xfrom
Open
Generic exception message to catch-all exception#97pinclau wants to merge 2 commits intomezzio:3.0.xfrom
pinclau wants to merge 2 commits intomezzio:3.0.xfrom
Conversation
Signed-off-by: pinclau <claudiu@dotkernel.com>
Member
|
@mezzio/tsc-reviewers |
froschdesign
requested changes
Mar 20, 2026
| * @param (callable():ResponseInterface)|ResponseFactoryInterface $responseFactory | ||
| */ | ||
| public function __construct(AuthorizationServer $server, $responseFactory) | ||
| public function __construct(AuthorizationServer $server, $responseFactory, ?LoggerInterface $logger = null) |
Member
There was a problem hiding this comment.
We have here a typical problem: nobody knows about it.
There is a simple rule: what is not documented does not exist.
Member
There was a problem hiding this comment.
The related factory should also be extended:
mezzio-authentication-oauth2/src/AuthorizationMiddlewareFactory.php
Lines 16 to 20 in 2733dae
The Psr\Container\ContainerInterface defines a has method which can be used here.
Author
There was a problem hiding this comment.
@froschdesign i made changes to the related factory
What should we do about the documentation?
Signed-off-by: pinclau <claudiu@dotkernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #92 issued by @marcguyer and implements his "suggested fix". I added a test for the new
LoggerInterface