Upgrade nikic/fast-route to version 2.0.0-beta1#51
Upgrade nikic/fast-route to version 2.0.0-beta1#51gsteel wants to merge 1 commit intomezzio:3.15.xfrom
nikic/fast-route to version 2.0.0-beta1#51Conversation
Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
added
Enhancement
| "laminas/laminas-stdlib": "^3.19.0", | ||
| "mezzio/mezzio-router": "^3.18 || ^4.0.1", | ||
| "nikic/fast-route": "^1.2", | ||
| "nikic/fast-route": "^2.0.0-beta1", |
There was a problem hiding this comment.
From my PoV, this is OK, but we need to wait for a stable release before releasing on our end
There was a problem hiding this comment.
From my PoV, this is OK, but we need to wait for a stable release before releasing on our end
That can be a problem, waiting for a stable release.
As the current beta is 8 months old and there are no signs that a stable release will coming soon.
It is quite unsual to require a beta package, but still ...
There was a problem hiding this comment.
We need a stable release. But another option could be to release a beta version here as well.
Or we can put the topic on the agenda for the next meeting and ask if @lcobucci will be present.
There was a problem hiding this comment.
Version 1 works just fine - I made this patch more so that I could test the beta and provide some feedback to @lcobucci eg nikic/FastRoute#302 - There's no rush!
4 participants
Also, bumps dev deps and refreshes the lock.
Please don't merge… Unless we want to release this with v2 beta of fast-route.
The BC break involves adding
ConfigureRoutesto the union ofFastRouteRouter's constructor. Considering it's soft final, andRouteCollectorimplementsConfigureRoutes, it doesn't seem like a BC break to me…