refactor: replace mocked metadata with direct init and declare remaining metadata classes as final
#109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing metadata classes as `final` Signed-off-by: mmalac <[email protected]>
gsteel
approved these changes
Oct 13, 2025
| * 1: Metadata\AbstractMetadata | ||
| * }> | ||
| */ | ||
| public function validMetadataTypes(): Generator |
Member
There was a problem hiding this comment.
Suggested change
| public function validMetadataTypes(): Generator | |
| public static function validMetadataTypes(): Generator |
gsteel
added
Enhancement
gsteel
changed the title
final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors metadata classes by:
@finalannotations with actualfinalclass declarations.