Drop support for PHP 8.1, add support for PHP 8.5 #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving PHPUnit on 9.x until we can get rid of Prophecy Signed-off-by: George Steel <[email protected]>
gsteel
added
Enhancement
Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
php8.5
branch
2 times, most recently
from
89df0fb to
56b75fd
Compare
…CollectionTrait` - It is impossible to support PHP 8.5 without altering the signature. Signed-off-by: George Steel <[email protected]>
Ocramius
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving PHPUnit on 9.x until we can get rid of Prophecy
There's a technical BC Break here.
generateSelfLinkis declared abstract in 2 different traits with slightly different signatures.IMO adding the return type is least worst option and means that the
GenerateSelfLinkTraitis now unused so its been deprecated.