Initial setup of the component by Ocramius · Pull Request #1 · mezzio/mezzio-valinor

Ocramius · 2026-03-02T18:26:01Z

This patch provides

initial documentation
setup necessary for migration to a mezzio/* package
basic integration testing with a full mezzio/mezzio skeleton-alike installation
parsing of parsed BODY parameters and route parameters
CI setup
parsing of QUERY parameters ( see WIP: feat: add HTTP request mapping support CuyZ/Valinor#748 ) ( deferred to Implement and document the usage of request attributes for request payload extraction #2 )

src/DefaultMapperBuilderFactory.php

.gitattributes

.github/workflows/release-on-milestone-closed.yml

src/DefaultMapperBuilderFactory.php

docs/book/v1/intro.md

src/ConfigProvider.php

src/DefaultMapperBuilderFactory.php

composer.json

test/Integration/MezzioSkeletonIntegrationTest.php

This patch provides * [x] initial documentation * [x] setup necessary for migration to a `mezzio/*` package * [x] basic integration testing with a full `mezzio/mezzio` skeleton-alike installation * [x] parsing of parsed BODY parameters and route parameters * [x] CI setup * [ ] parsing of QUERY parameters ( see CuyZ/Valinor#748 )

Should also fix: ``` Invalid workflow file: .github/workflows/continuous-integration.yml#L11 error parsing called workflow ".github/workflows/continuous-integration.yml" -> "laminas/workflow-continuous-integration/.github/workflows/continuous-integration.yml@1.43.0" : failed to fetch workflow: reference to workflow should be either a valid branch, tag, or commit ``` Ref: https://github.com/Roave/mezzio-valinor/actions/runs/22590162608

Most scaffolding of this component was copied from `laminas/laminas-session`, and here we are removing all the remaining references.

…rage to run

…tegrates with `laminas/laminas-servicemanager`

…ests

Fixes: ``` Error: docs/book/v1/intro.md:101:3 MD047/single-trailing-newline Files should end with a single newline character ``` Ref: https://github.com/mezzio/mezzio-valinor/actions/runs/22627736362/job/65568913920?pr=1#step:3:508

Ocramius · 2026-03-03T14:45:29Z

Well, I have no idea why the Backward Compatibility Check fails...

Probably because 1.0.x has no "require" section

test/DefaultMapperBuilderFactoryTest.php

Ref: #1 (comment)

This is a small and security-sensitive codebase: each branch **must** come with respective testing and examples.

Ocramius · 2026-03-03T15:57:04Z

I'll sign the commits before merge: don't want to rebase before doing that

gsteel

LGTM! I don't have much to add…

Some kind of automatic mapping would be very attractive to users - ATM, we have that via a merged array, but no control over the merge order - maybe the user wants body to override route attributes for example.

Am I right in understanding that in CuyZ/Valinor#748 usage of Attributes such as #[FromRoute] is mandatory?

gsteel · 2026-03-03T15:46:43Z

src/DefaultMapperBuilderFactory.php

+        return $next(array_merge(
+            $body,
+            $routeParameters,
+        ));


So the potential conflicts here will be solved by #2? i.e. users explicitly define where the data comes from by annotating the DTO with #FromRoute etc and using HttpRequest::fromPsr($request, $routeParamsExtractedFromReqAttribute) here?

Correct, deferring this to #2 entirely

COPYRIGHT.md

LICENSE.md

…ypal phase Ref: #1 (comment) Ref: #1 (comment)

Ocramius · 2026-03-22T12:59:46Z

Am I right in understanding that in CuyZ/Valinor#748 usage of Attributes such as #[FromRoute] is mandatory?

That's pretty much what I'm toying around with in #2 :D

Ocramius added this to the 1.0.0 milestone Mar 2, 2026

Ocramius self-assigned this Mar 2, 2026

Ocramius added the enhancement New feature or request label Mar 2, 2026

Ocramius commented Mar 2, 2026

View reviewed changes

src/DefaultMapperBuilderFactory.php Outdated Show resolved Hide resolved

Ocramius commented Mar 2, 2026

View reviewed changes

.gitattributes Outdated Show resolved Hide resolved

Ocramius commented Mar 2, 2026

View reviewed changes

.github/workflows/release-on-milestone-closed.yml Show resolved Hide resolved

Ocramius commented Mar 2, 2026

View reviewed changes

src/DefaultMapperBuilderFactory.php Show resolved Hide resolved

romm reviewed Mar 2, 2026

View reviewed changes

docs/book/v1/intro.md Show resolved Hide resolved

docs/book/v1/intro.md Show resolved Hide resolved

src/ConfigProvider.php Outdated Show resolved Hide resolved

src/DefaultMapperBuilderFactory.php Show resolved Hide resolved

composer.json Outdated Show resolved Hide resolved

weierophinney reviewed Mar 2, 2026

View reviewed changes

test/Integration/MezzioSkeletonIntegrationTest.php Outdated Show resolved Hide resolved

Ocramius added 6 commits March 3, 2026 15:15

Added mutation testing checks

d9d0859

Enforce running infection via PCOV

4c52998

Replaced all leftover references to laminas-session

2d453f9

Most scaffolding of this component was copied from `laminas/laminas-session`, and here we are removing all the remaining references.

Ensure that pcov is installed in CI, allowing mutation testing cove…

4763b52

…rage to run

Ocramius force-pushed the feature/repository-setup branch from 17f53ca to 4763b52 Compare March 3, 2026 14:15

Ocramius added 3 commits March 3, 2026 15:30

Better testing for the ConfigProvider, checking that it actually in…

c9b2684

…tegrates with `laminas/laminas-servicemanager`

Verify that scalar value casting is enabled by default, also during t…

6ef54ed

…ests

Correcting trailing file \n

f4a5988

Fixes: ``` Error: docs/book/v1/intro.md:101:3 MD047/single-trailing-newline Files should end with a single newline character ``` Ref: https://github.com/mezzio/mezzio-valinor/actions/runs/22627736362/job/65568913920?pr=1#step:3:508

romm reviewed Mar 3, 2026

View reviewed changes

test/DefaultMapperBuilderFactoryTest.php Show resolved Hide resolved

Ocramius mentioned this pull request Mar 3, 2026

Implement middleware that converts Valinor mapping errors into ApiProblems #3

Open

Ocramius added 4 commits March 3, 2026 16:23

Removed reference to non-existing file

ad18341

Ref: #1 (comment)

Corrected indentation of NOWDOC block

503bd1b

Ref: #1 (comment)

Defer parsing request POST/QUERY/route parameters to #2

08577fa

Raised mutation testing requirements to 100%

6a372ca

This is a small and security-sensitive codebase: each branch **must** come with respective testing and examples.

Ocramius requested a review from gsteel March 3, 2026 15:34

gsteel reviewed Mar 3, 2026

View reviewed changes

Correcting leftover copyright notices, introduced during local protot…

ed3ceea

…ypal phase Ref: #1 (comment) Ref: #1 (comment)

Ocramius merged commit 60506da into 1.0.x Mar 22, 2026
24 of 26 checks passed

Ocramius deleted the feature/repository-setup branch March 22, 2026 13:01

Conversation

Ocramius commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ocramius commented Mar 3, 2026

Uh oh!

Uh oh!

Ocramius commented Mar 3, 2026

Uh oh!

gsteel left a comment

Choose a reason for hiding this comment

Uh oh!

gsteel Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Ocramius Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Ocramius commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ocramius commented Mar 2, 2026 •

edited

Loading