#3 課題 (takashima.nobutaka) #11
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mf-sakura
reviewed
Mar 30, 2020
There was a problem hiding this comment.
@ntakashima
概ね良さそうです！
多分時間がなかったんだろうなという気がしますが、ちゃんと実装するならdecrementHandlerの修正が必要かなと思います。
Comment on lines
+27
to
+32
| // FIXME 本来は group とか使うのかな.. 時間なく諦めた | ||
| e.GET("/incr", methodNotAllowedHandler) | ||
| e.PATCH("/incr", methodNotAllowedHandler) | ||
| e.PUT("/incr", methodNotAllowedHandler) | ||
| e.DELETE("/incr", methodNotAllowedHandler) | ||
|
|
There was a problem hiding this comment.
てか課題2 は何も実装しなくてよかったのか！
echoがmethodの判別してくれるので不要という課題でした！
echoのGroupは、/v1/みたいなprefixを管理する為のものですね。
Comment on lines
+92
to
+95
| incrRequest := incrRequest{} | ||
| if err := c.Bind(&incrRequest); err != nil { | ||
| return echo.NewHTTPError(http.StatusInternalServerError, "Internal Server Error") | ||
| } |
There was a problem hiding this comment.
多分時間の問題だったと思うんですが、incrRequestを使ってるのが違和感あります
There was a problem hiding this comment.
急ぎでやったから（という言い訳
dncrResponse 作ってたけど課題4の実装でデグレってしまった
Comment on lines
+91
to
+99
| func decrementHandler(c echo.Context) error { | ||
| incrRequest := incrRequest{} | ||
| if err := c.Bind(&incrRequest); err != nil { | ||
| return echo.NewHTTPError(http.StatusInternalServerError, "Internal Server Error") | ||
| } | ||
| dr := &dncrResponse{ | ||
| Counter: counter, | ||
| } | ||
| return c.JSON(http.StatusOK, dr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題実装しました！
時間がなく簡易実装になっちゃいましたが..
てか課題2 は何も実装しなくてよかったのか！