第７回の課題（大倉） #40
Open
第７回の課題（大倉） #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaKO8Ki
reviewed
Apr 15, 2020
Comment on lines
+73
to
+85
| test_user := domain.User{ | ||
| FirstName: "roger", | ||
| LastName: "federer", | ||
| } | ||
|
|
||
| tx := GetTestTransaction() | ||
| id, err := Store(tx, test_user) | ||
| if err != nil { | ||
| return | ||
| } | ||
| test_user.ID = id | ||
| tx.Commit() | ||
|
|
There was a problem hiding this comment.
fixture使うとymlでテストデータ管理できたりして便利なんですが、おそらくテストケース別にyml書いたり今のところはできないので何が最適解なのかなーといつも思ってます。
https://github.com/mf-https://github.com/go-testfixtures/testfixtures
golang_study/test/api/interfaces/database/user_repository_test.go
Lines 20 to 49 in d2f4472
There was a problem hiding this comment.
共通したテストデータを使い回す場合にはfixtureだと便利かなーというイメージです。
普通に前後でデータ作って終了時に消すでもいいと思います。
There was a problem hiding this comment.
なるほどです
これ、書いてて思ったのは rspec+factory_botって便利すぎるよね
せめてgoにもfactory_bot的なmoduleがあれば・・・
Railsもfixtureは使いづらいよね・・・
TaKO8Ki
reviewed
Apr 15, 2020
| @@ -93,4 +115,5 @@ func TestFirstNameLike(t *testing.T) { | |||
| } | |||
| }) | |||
| } | |||
| db.Exec("delete from users;") | |||
There was a problem hiding this comment.
ここはdeferで書いてしまったらいいと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixuture使うところまで頑張れませんでした 🙈