[WIP] 第11回Go勉強会の課題@luccafort #59
Draft
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main関数内でchannel/basic/main.goの実装内容をGoroutineとChannelを使って実装 変更点 - Channelが返す型はStringからIntegerに変更 - Goroutineで実行する無名関数の引数として任意の数値を指定するように変更
受信専用チャンネルを使ってSleepSortを実装 受信専用チャンネルではclose(channel)できなかったので関数を2つにわけて実装する苦肉の策 SleepSortを行う関数を実装、WaitGroupで処理の同期を実装（でも引数にチャンネル取るのがダサい）
luccafort
commented
Apr 29, 2020
| return ch | ||
| } | ||
|
|
||
| func sleepSortCh(ch chan int, nums []int) chan int { |
There was a problem hiding this comment.
引数にチャンネルを取ってるが依存してしまっているので依存しないようにしたいが考えつかなかった。
| count := len(nums) | ||
| ch := make(chan int, count) | ||
| go func(nums []int) { | ||
| defer close(ch) |
There was a problem hiding this comment.
受信専用チャンネルだとクローズできなかった（送信側がクローズできるべきなのでそれはそう）ので関数に切り出してGoroutineするところで defer close() するようにした……がもうちょいなんかやりようがある気がする。
| } | ||
|
|
||
| func sleepSortCh(ch chan int, nums []int) chan int { | ||
| var wg sync.WaitGroup |
There was a problem hiding this comment.
WaitGroupで実装したがerrgroup.Groupで実装したほうがよかったかも。
There was a problem hiding this comment.
通常こういう処理を行うときって外部APIへの通信だったりするのでそのレスポンスを待ち受けるならエラーが返る可能性を考慮して errgroup.Group じゃないと駄目そう。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題
https://mf.esa.io/posts/132902
channel/basicを実装する<-Channelを実装するfor range Channelを実装するclose(Channel)を実装する