Skip to content

Migrate first batch of HAML views to ERB with snapshot support#5

Closed
mfo wants to merge 1 commit into
US/haml-to-herbfrom
codex/migrate-haml-views-to-html-erb
Closed

Migrate first batch of HAML views to ERB with snapshot support#5
mfo wants to merge 1 commit into
US/haml-to-herbfrom
codex/migrate-haml-views-to-html-erb

Conversation

@mfo

@mfo mfo commented Sep 17, 2025

Copy link
Copy Markdown
Owner

Summary

  • add a view snapshot hook for recording and checking rendered HTML in view specs
  • add missing view specs and HTML snapshots for the first batch of HAML templates
  • migrate the first 10 HAML views in the batch to ERB while preserving behaviour

Testing

  • SNAPSHOT=1 bundle exec rspec spec/views/administrateurs/_main_navigation.html.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateurs/_main_navigation.html.haml_spec.rb
  • bundle exec herb analyze . --non-interactive
  • bundle exec erb_lint app/views/administrateurs/_main_navigation.html.erb app/views/administrateurs/_login_banner.html.erb app/views/administrateurs/_groups_header.html.erb app/views/administrateurs/_breadcrumbs.html.erb app/views/administrateur_mailer/notify_service_without_siret.html.erb app/views/administrateur_mailer/notify_procedure_expires_when_termine_forced.html.erb app/views/administrateur_mailer/api_token_expiration.html.erb app/views/administrateur_mailer/activate_before_expiration.html.erb app/views/administrate/application/_pagination.html.erb app/views/admin/_closed_mail_template_attestation_inconsistency_alert.html.erb

https://chatgpt.com/codex/tasks/task_e_68ca60d29dcc83218576331ce4fab7ae

@mfo

mfo commented Sep 17, 2025

Copy link
Copy Markdown
Owner Author

autre tentative ac un autre prompt a venir

@mfo mfo closed this Sep 17, 2025
mfo added a commit that referenced this pull request Mar 5, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
5c9b1fc 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
ae94fb9 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
5739737 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
2159733 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
5c0ff7e 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
3637778 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
389a266 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 16, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
21b1a60 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 16, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
7f87828 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 16, 2026
@mfo @claude
Tech: migrate all attachment usages to new components
2e1ad24 
Migrate all existing usages:
- MultipleComponent → FileFieldComponent with drop_zone: :integrated
- UniqueComponent → FileFieldComponent with drop_zone: :none

All functionality preserved, architecture simplified.
Affects 17 files across views and components.

Part of attachment components refactoring (#5/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mfo