Skip to content

Migrate initial admin views from HAML to ERB with snapshot tooling#6

Closed
mfo wants to merge 1 commit into
mainfrom
codex/migrate-haml-views-to-html-erb-awe2xp
Closed

Migrate initial admin views from HAML to ERB with snapshot tooling#6
mfo wants to merge 1 commit into
mainfrom
codex/migrate-haml-views-to-html-erb-awe2xp

Conversation

@mfo

@mfo mfo commented Sep 17, 2025

Copy link
Copy Markdown
Owner

Summary

  • add a reusable snapshot helper for view specs to capture and compare rendered HTML output
  • introduce missing view specs and stored snapshots for the first batch of admin and mailer templates
  • convert the first ten admin-related HAML templates to ERB while keeping structure intact

Testing

  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateurs/_closed_mail_template_attestation_inconsistency_alert.html.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrate/application/_pagination.html.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateur_mailer/activate_before_expiration.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateur_mailer/api_token_expiration.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateur_mailer/notify_procedure_expires_when_termine_forced.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateur_mailer/notify_service_without_siret.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateurs/_breadcrumbs.html.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateurs/_groups_header.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateurs/_login_banner.html.haml_spec.rb
  • CHECK_SNAPSHOT=1 bundle exec rspec spec/views/administrateurs/_main_navigation.html.haml_spec.rb

https://chatgpt.com/codex/tasks/task_e_68ca8c79a94483219d6c209dcafb27a6

mfo added a commit that referenced this pull request Mar 5, 2026
@mfo @claude
Tech: update CSS for new attachment components
177a0a4 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: update CSS for new attachment components
a2122e9 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: update CSS for new attachment components
3735686 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: update CSS for new attachment components
b1f82d7 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: update CSS for new attachment components
e7dd06d 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: update CSS for new attachment components
78a10a2 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 6, 2026
@mfo @claude
Tech: update CSS for new attachment components
83618a3 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 16, 2026
@mfo @claude
Tech: update CSS for new attachment components
f446732 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 16, 2026
@mfo @claude
Tech: update CSS for new attachment components
2052631 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
mfo added a commit that referenced this pull request Mar 16, 2026
@mfo @claude
Tech: update CSS for new attachment components
b2257e5 
Add CSS classes for FileFieldComponent:
- .attachment-field for common styles
- .attachment-field--single for max=1 cases
- .attachment-field--multiple for max>1 cases

Keep existing .attachment-drop-zone styles (reused by DropZoneDecorator).
Maintain legacy styles for backward compatibility during transition.

Part of attachment components refactoring (#6/7)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@mfo mfo closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mfo