prevent unnecessary recompilation#402
Open
lzy1g1225 wants to merge 1 commit intomfontanini:masterfrom
Open
Conversation
…he whole project when the build type changed
lzy1g1225
changed the title
lzy1g1225
changed the title
Author
|
Looks like the appveyor build check failed because tests and examples didn't update include path for config.h. Will add this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that libtins got recompile everytime which drive me crazy when I switched debug/release mode or when I switched from win32/linux.
The reason is the cmake generates config.h for those build types into source folder and got the config.h overwritten, which causing the compiler to recompile the whole project.
I suggest to generate config.h in binary directory. That make every config.h stay with there own build type.