Improve cmake package install#535
Open
Faroito wants to merge 3 commits intomfontanini:masterfrom
Open
Conversation
- Use CMakePackageConfigHelpers macro to generate the config file. - Uses relative path to seach for libtins includes. - Install the FindPCAP.cmake file & search for PCAP dependency - Set the include directory interface directly on target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR tries to uses more modern CMake mecanism for libtins config file. The main changes are:
FindPCAP.cmakein the install tree to be able to find automatically the dependency when searching for libtinsIt also fixes #101