Skip to content

Using autotests - #38

Open
FrederikHeber wants to merge 3 commits into
mfragkoulis:PiCO_QL-application-releasefrom
FrederikHeber:Using_Autotests
Open

Using autotests#38
FrederikHeber wants to merge 3 commits into
mfragkoulis:PiCO_QL-application-releasefrom
FrederikHeber:Using_Autotests

Conversation

@FrederikHeber

Copy link
Copy Markdown
Contributor

Hey Marios,

I stumbled upon your project which seems perfect for adding SQL querying to the internal state of my molecular dynamics software package molecuilder.

I made some smaller enhancements ... this is the second and larger change :):

  • I basically made out-of-source builds possible (i.e. have a subfolder build in the src branch and call ../configure in there) using $(abs_top_srcdir) and so on.
  • I modified all of your tests to run using autotest (test-driver from autotools) which is cleaner than your solution with running run_tests.sh in the installed folder. They now reside in a distinct folder "tests" and each has a post folder with .._success.txt and a pre (if needed) with any data.txt or solomon.txt.
  • I renamed your "test" target to check which is the default name with autotools projects as far as I know, test is used with CMake.

I hope your like the changes. On my system (ubuntu, gcc) make clean, distclean, check, uninstall, install, ... run all fine. I could not check for VisualStudio and alikes, since I don't have these here.

If you don't like the tests changes, there is another branch with just out-of-source build changes and some cleanup to your configure.ac.

Kind regards,

Frederik

…ig.h.

- AC_CONFIG_AUX_DIR helps in keeping top folder clean.
- default config.h results in name collisions with other packages.
- before all tests were run in bindir, messing up possible system folders or
  not working due to access rights.
- now, tests are executed in subfolder tests using autotest in a clean manner.
@mfragkoulis

Copy link
Copy Markdown
Owner

Hi Frederik,

Changes look cool 👍
I will take some time shortly to take a closer look.

I have interest in the ways PiCO QL is used in different contexts, so if you would like to share more info regarding for instance your data model and queries that you issue, that would be great.

In addition, if there is some way that PiCO QL could benefit you more feel free to report a request for a new feature.

Kind regards,
Marios

@mfragkoulis mfragkoulis self-assigned this Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants