Wrap panic messages at the terminal width #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaru-iritani
force-pushed
the
wrap-panic-message
branch
from
c78ede6 to
a53592a
Compare
masaru-iritani
commented
Jun 4, 2025
internal/app/table_failed.go
Outdated
Comment on lines
118
to
121
| width, _, err := term.GetSize(int(os.Stdout.Fd())) | ||
| if err != nil { | ||
| width = 80 | ||
| } |
Contributor
Author
There was a problem hiding this comment.
96 is used for dividers. Should we use it here as well?
tparse/internal/app/table_failed.go
Line 47 in 553d204
Contributor
Author
There was a problem hiding this comment.
Tried using the terminal width (with a fallback to 96) for both panic messages and dividers in 4ee4e5e
ccoVeille
reviewed
Jun 4, 2025
Comment on lines
3
to
12
| import ( | ||
| "fmt" | ||
| "os" | ||
| "sort" | ||
| "strings" | ||
|
|
||
| "github.com/charmbracelet/lipgloss" | ||
|
|
||
| "github.com/mfridman/tparse/parse" | ||
| "golang.org/x/term" | ||
| ) |
Contributor
There was a problem hiding this comment.
The classic blocks for ordering are
- std lib
- new line
- external dependencies
- new line
- subpackages of current module
So here, it should be
import (
"fmt"
"os"
"sort"
"strings"
"github.com/charmbracelet/lipgloss"
"golang.org/x/term"
"github.com/mfridman/tparse/parse"
)
ccoVeille
approved these changes
Jun 6, 2025
mfridman
reviewed
Jun 11, 2025
go.mod
Outdated
| github.com/rivo/uniseg v0.4.7 // indirect | ||
| github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect | ||
| golang.org/x/sys v0.33.0 // indirect | ||
| golang.org/x/term v0.32.0 // indirect |
Contributor
Author
There was a problem hiding this comment.
Fixed by 8fe7ca3. Please let me know if you want me to squash commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Wrap the panic message at the terminal width.
Why
Closes #140
How Tested
tparseoutput is wrapped at 80 characters when the terminal width is 80 characters.Ref
The latest version without this change outputs a lot of trailing spaces which result in a lot of blank lines.