-
Notifications
You must be signed in to change notification settings - Fork 1.1k
improvement: link to document analytics from data room analytics #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughA navigational link to the full document analytics page was added below the document engagement heading in the analytics overview component. The link appears only if a document ID exists and is styled with icons and text, providing direct access to detailed analytics for the selected document. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AnalyticsOverviewComponent
User->>AnalyticsOverviewComponent: View analytics overview
AnalyticsOverviewComponent-->>User: Show document engagement heading
alt If documentId exists
AnalyticsOverviewComponent-->>User: Display "To full document analytics" link
User->>AnalyticsOverviewComponent: Click link
AnalyticsOverviewComponent-->>User: Navigate to full document analytics page
end
Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/datarooms/analytics/analytics-overview.tsx (1)
106-120
: LGTM! Well-implemented navigation link with good UX.The implementation correctly adds a navigational link to full document analytics with:
- Proper conditional rendering when
documentId
exists- Clean flex layout with appropriate spacing
- Good use of icons and hover effects
- Accessible link structure
Consider using a design system color token instead of the hardcoded
text-[#fb7a00]
for the FileIcon to maintain consistency with your design system.- <FileIcon className="h-4 w-4 text-[#fb7a00]" />{" "} + <FileIcon className="h-4 w-4 text-orange-500" />{" "}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/datarooms/analytics/analytics-overview.tsx
(2 hunks)
🔇 Additional comments (1)
components/datarooms/analytics/analytics-overview.tsx (1)
1-1
: LGTM! Imports are correctly added and used.The new imports for Link, FileIcon, and ChevronRight are all properly utilized in the navigation link implementation.
Also applies to: 5-5, 11-11
Summary by CodeRabbit