Skip to content

Disable buttons while document processes #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Disable buttons while document processes #1827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions components/links/link-sheet/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@ import useSWR from "swr";

import { useAnalytics } from "@/lib/analytics";
import { usePlan } from "@/lib/swr/use-billing";
import { useDocument } from "@/lib/swr/use-document";
import useDataroomGroups from "@/lib/swr/use-dataroom-groups";
import { useDomains } from "@/lib/swr/use-domains";
import useLimits from "@/lib/swr/use-limits";
import { LinkWithViews, WatermarkConfig } from "@/lib/types";
import { convertDataUrlToFile, fetcher, uploadImage } from "@/lib/utils";

import { isDocumentProcessing } from "@/components/documents/document-preview-button";
import { UpgradePlanModal } from "@/components/billing/upgrade-plan-modal";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
Expand Down Expand Up @@ -192,6 +194,15 @@ export default function LinkSheet({
},
);

// Document data for processing status check
const { document: documentData, primaryVersion } = useDocument();

// Check if document is processing (only for DOCUMENT_LINK)
const isDocumentCurrentlyProcessing =
linkType === LinkType.DOCUMENT_LINK && primaryVersion
? isDocumentProcessing(primaryVersion)
: false;

useEffect(() => {
setData(currentLink || DEFAULT_LINK_PROPS(linkType, groupId, !isDatarooms));
}, [currentLink]);
Expand Down Expand Up @@ -754,6 +765,7 @@ export default function LinkSheet({
<Button
type="submit"
loading={isSaving}
disabled={isDocumentCurrentlyProcessing}
onClick={(e) => handleSubmit(e, false)}
>
{currentLink ? "Update Link" : "Save Link"}
Expand All @@ -762,6 +774,7 @@ export default function LinkSheet({
type="button"
variant="outline"
loading={isLoading}
disabled={isDocumentCurrentlyProcessing}
onClick={(e) => handleSubmit(e, true)}
>
{currentLink ? "Update & Preview" : "Save & Preview"}
Expand Down
13 changes: 13 additions & 0 deletions ee/features/permissions/components/dataroom-link-sheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@ import z from "zod";

import { useAnalytics } from "@/lib/analytics";
import { usePlan } from "@/lib/swr/use-billing";
import { useDocument } from "@/lib/swr/use-document";
import useDataroomGroups from "@/lib/swr/use-dataroom-groups";
import { useDomains } from "@/lib/swr/use-domains";
import useLimits from "@/lib/swr/use-limits";
import { LinkWithViews } from "@/lib/types";
import { convertDataUrlToFile, fetcher, uploadImage } from "@/lib/utils";

import { isDocumentProcessing } from "@/components/documents/document-preview-button";
import {
DEFAULT_LINK_PROPS as BASE_DEFAULT_LINK_PROPS,
DEFAULT_LINK_TYPE as BASE_DEFAULT_LINK_TYPE,
Expand Down Expand Up @@ -136,6 +138,15 @@ export function DataroomLinkSheet({
},
);

// Document data for processing status check
const { document: documentData, primaryVersion } = useDocument();

// Check if document is processing (only for DOCUMENT_LINK)
const isDocumentCurrentlyProcessing =
linkType === LinkType.DOCUMENT_LINK && primaryVersion
? isDocumentProcessing(primaryVersion)
: false;

useEffect(() => {
setData(currentLink || DEFAULT_LINK_PROPS(linkType, groupId, !isDatarooms));
}, [currentLink]);
Expand Down Expand Up @@ -998,6 +1009,7 @@ export function DataroomLinkSheet({
: "outline"
}
loading={isSaving}
disabled={isDocumentCurrentlyProcessing}
onClick={(e) => handleSubmit(e, false)}
>
{currentLink ? "Update Link" : "Save Link"}
Expand All @@ -1009,6 +1021,7 @@ export function DataroomLinkSheet({
type="button"
variant="link"
loading={isLoading}
disabled={isDocumentCurrentlyProcessing}
onClick={(e) => handleSubmit(e, true)}
className="flex items-center gap-2"
>
Expand Down