fix: resolve upgrade modal taking full viewport height

[nielskaspers]

Summary

Fixes the upgrade plan modal taking up the entire viewport height by removing the conflicting min-h-fit class.

Issue

Fixes #2116

Changes

• Removed min-h-fit class from upgrade-plan-modal.tsx and upgrade-plan-modal-with-discount.tsx that was overriding max-h-[90vh]

Testing

1. Open Papermark and trigger the upgrade plan modal
2. Verify the modal no longer takes up the entire viewport
3. Verify modal content is still properly scrollable

Summary by CodeRabbit

• Style
  • Refined layout styling of upgrade plan modals to improve visual consistency.

[vercel]

@nielskaspers is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df961d02-e65a-4c61-8074-40568e9debce

📥 Commits

Reviewing files that changed from the base of the PR and between fd7d017 and 645ad84.

📒 Files selected for processing (2)

• components/billing/upgrade-plan-modal-with-discount.tsx
• components/billing/upgrade-plan-modal.tsx

---

Walkthrough

The min-h-fit Tailwind class was removed from the DialogContent styling in both upgrade plan modal components. This change allows the max-h-[90vh] constraint to take precedence over the minimum height specification, affecting how the modals size themselves vertically while preserving all other styling properties.

Changes

Cohort / File(s)	Summary
Upgrade Modal Styling components/billing/upgrade-plan-modal.tsx, components/billing/upgrade-plan-modal-with-discount.tsx	Removed min-h-fit Tailwind class from DialogContent to allow max-h-[90vh] constraint to take effect. Modal overflow and background styling remain unchanged.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing min-h-fit to fix the modal height issue and ensure it respects the max-h-[90vh] constraint.
Linked Issues check	✅ Passed	The PR fully addresses issue #2116 by removing the min-h-fit class from both modal files, allowing the max-h-[90vh] constraint to work as intended.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the modal height issue; no unrelated modifications are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

[nielskaspers]

I have read the CLA Document and I hereby sign the CLA