Skip to content

Add example of batch reading from Kafka with context propagation#311

Merged
mfvanek merged 22 commits into
masterfrom
issue-224
Oct 19, 2025
Merged

Add example of batch reading from Kafka with context propagation#311
mfvanek merged 22 commits into
masterfrom
issue-224

Conversation

@marijarin

@marijarin marijarin commented Sep 13, 2025

Copy link
Copy Markdown
Collaborator

Closes #224

There is a difference between Kotlin and Java modules i.e. in Kotlin app trace ids are equal for single record and batch record listening though in Java apps they are different.
Also I didn't complete the work on increasing test coverage. Lines with forming error spans in KafkaReadingService are not covered. So I wrote a test for a non-reactive Java app, which solves partially this problem (it is KafkaTracingTest), but I am not sure of this one.

@marijarin

marijarin commented Sep 13, 2025

Copy link
Copy Markdown
Collaborator Author

I found a checkstyle problem in build, but need some time to solve it as after merging master branch got a Gradle error
Required by: project :buildSrc > Could not resolve io.freefair.gradle:lombok-plugin:8.14.2. > Could not get resource 'https://plugins.gradle.org/m2/io/freefair/gradle/lombok-plugin/8.14.2/lombok-plugin-8.14.2.pom'. > Could not GET 'https://plugins.gradle.org/m2/io/freefair/gradle/lombok-plugin/8.14.2/lombok-plugin-8.14.2.pom'. > Got SSL handshake exception during request. It might be caused by SSL misconfiguration > PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

I tried to reset HEAD then rearrange imports and after that remerge master to fix checkstyle errors, but need some time to fix this error. May be it won't appear in my Linux laptop

UPD the problem was with Gradle JVM

Comment thread config/checkstyle/checkstyle.xml Outdated
Comment thread db-migrations/src/main/resources/db/changelog/sql/add_span_column.sql Outdated
Comment thread spring-boot-3-demo-app-kotlin/src/main/resources/application.yml Outdated
@mfvanek mfvanek changed the title Issue 224 Add example of batch reading from Kafka with context propagation Sep 14, 2025
@codecov

codecov Bot commented Oct 3, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.03846% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.54%. Comparing base (fc50dce) to head (6e3d9dc).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...g/boot3/kotlin/test/service/KafkaReadingService.kt 96.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #311      +/-   ##
============================================
+ Coverage     94.24%   96.54%   +2.29%     
- Complexity      110      135      +25     
============================================
  Files            39       42       +3     
  Lines           313      376      +63     
  Branches         10        8       -2     
============================================
+ Hits            295      363      +68     
+ Misses           10        7       -3     
+ Partials          8        6       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marijarin marijarin requested a review from mfvanek October 13, 2025 16:11
@mfvanek mfvanek merged commit fb66d9c into master Oct 19, 2025
3 checks passed
@mfvanek mfvanek deleted the issue-224 branch October 19, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add example of batch reading from Kafka with context propagation

2 participants