Remove blank undescore with _{side} and side naming is empty.#560
Closed
RemiCuxac wants to merge 1 commit into
Closed
Remove blank undescore with _{side} and side naming is empty.#560RemiCuxac wants to merge 1 commit into
RemiCuxac wants to merge 1 commit into
Conversation
Avoid ending a object name with an underscore
Member
|
hi @RemiCuxac |
Contributor
Author
|
Good idea, thank you for your suggestion ! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid ending a object name with an underscore
Description of Changes
When using a naming convention like this :
and with _{side} at end of joints or controls naming rule, objects may ends with a blank underscore with nothing behind. The fix could avoid this behavior.
I assume this naming convention isn't very conventional, but in order to make mGear more robust with more situations, i thought it could be nice to suggest it.
Testing Done
Related Issue(s)