Skip to content

Comments

gameplay: flying, more horizontal speed#124

Closed
cryham wants to merge 4 commits intomgerhardy:masterfrom
cryham:flying-horiz
Closed

gameplay: flying, more horizontal speed#124
cryham wants to merge 4 commits intomgerhardy:masterfrom
cryham:flying-horiz

Conversation

@cryham
Copy link
Contributor

@cryham cryham commented Mar 7, 2025

I like it more, makes gameplay faster. Feels less heavy.
I think in Ugh flying sideways was even faster. But this value is good.

@mgerhardy
Copy link
Owner

Maybe make it a config option - this might be bad for touch devices

@cryham
Copy link
Contributor Author

cryham commented Mar 7, 2025

Maybe make it a config option - this might be bad for touch devices

Ok. So I should add in UI Settings - Game a new checkbox e.g. "Faster flying"?

const float maxSpeed = 8.0f;
const b2Vec2 force = getMass() * _acceleration;
b2Vec2 force = getMass() * _acceleration;
force.x *= 2.5f; // more horizontal
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this into (the 2.5)a constant into Map.h

@mgerhardy
Copy link
Owner

Maybe make it a config option - this might be bad for touch devices

Ok. So I should add in UI Settings - Game a new checkbox e.g. "Faster flying"?

not necessarily an ui option - but an option so we can change the setting in the config dependent on whether this is a touch, mobile, web or ...

@cryham
Copy link
Contributor Author

cryham commented Mar 9, 2025

Ah right. I will add it.

@cryham
Copy link
Contributor Author

cryham commented Mar 9, 2025

Okay I added a var in Map.h and now in config.lua I set it to 2.5 on PC, and default 1.0 stays on devices/html.

@mgerhardy
Copy link
Owner

can you please rebase this and remove the merge commit?

@cryham
Copy link
Contributor Author

cryham commented Mar 9, 2025

can you please rebase this and remove the merge commit?

Well I can try. I fixed a merge confict in it. I guess I got used to merge workflow etc.

@cryham
Copy link
Contributor Author

cryham commented Mar 9, 2025

Okay rebase failed. It was easier for me to make a new branch and PR: #138

@cryham cryham closed this Mar 9, 2025
@cryham cryham deleted the flying-horiz branch March 9, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants