added arrow to target cave #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgerhardy
reviewed
Mar 30, 2025
| @@ -7,27 +7,35 @@ namespace caveexpress { | |||
| class TargetCaveMessage: public IProtocolMessage { | |||
| private: | |||
| uint8_t _targetCave; // 0 none, 100 stone | |||
| float _angle; // arrow angle to target cave -1 if none | |||
There was a problem hiding this comment.
there is no need to send this as a 4 byte float value - uint16_t would be enough here.
mgerhardy
reviewed
Mar 30, 2025
| @@ -154,6 +158,8 @@ void Player::update (uint32_t deltaTime) | |||
| { | |||
| IEntity::update(deltaTime); | |||
|
|
|||
| sendTargetCaveAngle(); | |||
There was a problem hiding this comment.
doing this every frame is a waste of traffic. it would be better to send the position once the target cave is selected and do the whole arrow thing client side.
There was a problem hiding this comment.
Right, I don't know yet how to do it on client side, which files/classes would I need to edit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is even better around player, since you focus on sceen center and flying instead of looking at Hud above. But yeah looks a bit artificial