Update drag-coordinator.indexOf implementation to not use findIndex … #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s hasMany does not support this
dgavey
requested changes
Sep 28, 2020
Collaborator
dgavey
left a comment
dgavey
left a comment
There was a problem hiding this comment.
Left some feedback, also I will need a test for your case of an array proxy as well before I can accept this PR. There are already some tests for ember-data in the test suite, you should be able to just build off of those.
|
|
||
|
|
||
| function indexOf(items, a) { | ||
| return items.findIndex(function (element) { |
Collaborator
There was a problem hiding this comment.
@ianpetzer Interesting that the findIndex didn't work in your case. I guess the hasMany proxy array doesn't implement this function.
| return items.findIndex(function (element) { | ||
| return isEqual(element, a); | ||
| var returnIndex=null; | ||
| items.forEach(function(element, index) { |
Collaborator
There was a problem hiding this comment.
@ianpetzer This seems ok, but it doesn't break when it finds an item like the findIndex does. If you use a "for in" you can break sooner. That will make for more performant code.
https://stackoverflow.com/questions/2641347/short-circuit-array-foreach-like-calling-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as hasMany does not support this