Add compatibility for Ember 4

[ndekeister-us]

Breaking

Officially drop support for Node < 12

Drop support for Ember <3.24

Chore

Upgrade to Ember 4

• run ember-cli-update --to 4.4.0 and yarn install

Also

• specify node version supported in package.json (>= 12)
• update ember-classic-decorator devDeps to v3.0.1 (v2 was not compatible with Ember 4)
• update ember-data devDeps to 4.4.x (v3 was not compatible with Ember 4)
• run yarn-deduplicate && yarn install to clean the yarn.lock
• remove jshint config files used in tests (not relevant anymore, was introduced with first versions of Ember, we now use eslint in tests)
• lint
  • fix some lint errors in test
  • fix template lint errors
  • ⚠️ temporarily move eslint and template lint error to a warning -> Goal of this PR is to make this repo compatible with Ember 4 so that consumers using Ember 4 can use it ; refactoring whole addon to native class / glimmer may introduce some side effects and it seems not a blocking for Ember 4

Remove object-bin export

Taken from #194 (file no longer exists in ./addon/component) should make embroider happy

Build

Remove ember-decorators from devDeps

It was not used by this repo

[ndekeister-us]

Motivation

We are working on an old private project which is being migrated to Ember 4. At this moment v0.9.0 is not compatible with Ember 4, so it block us, this PR make ember-drag-drop compatible with Ember 4 and unblock us.

I'm not tackling refactor to glimmer and native class yet on this PR (only switched errors to warnings) because it could brings side effects and I don't have enough knowledge of this repo / our old repo to be sure I will detect them.

If this PR is

• accepted 🎉 I will maybe take some times to work on these refactors and submit some PRs (would be happy to discuss with you @mharris717 , ndekeister#0721 in Ember Discord, we can maybe think about a roadmap / see if some other people are interested to work on it / contribute to this cool addon)
• not accepted 😿 we will probably refactor our drag'n'drop implementation with another packages (but it could be nice to specify in the README.md that addon is not compatible with Ember 4 🙏 )

---

CI run -> https://github.com/ndekeister-us/ember-drag-drop/pull/1/checks (only embroider-optimized failing, didn't investigated

[boris-petrov]

cc @dgavey

[dgavey]

Ok I'll take a look at it.

[tehhowch]

bump - looking forward to seeing this work!

[tehhowch]

When I yarn, I get warnings about missing a peer dep of @babel/core@^7, so that should probably be added here. Other than that, the changes seem sensible, given that the larger lint changes are marked TBD.

Were the existing lint changes from autofixing before the decision to defer that to a followup PR?

[IBRAHIMDANS]

When is this mr going to be merged ? @tehhowch