Add update_contact_list endpoint to add user to a list #73
Conversation
Missing endpoint that i need for my project
|
Code Climate has analyzed commit 36b78f5 and detected 0 issues on this pull request. View more on Code Climate. |
|
I'm new to active campaign. @robypez Should I be looking into this gem or the active-campaign-rails gem, or just build it directly into the system? I'm not sure if this gem is working based on the status and dates I'm seeing on requests, commits, etc |
|
I'd accept the PR with test coverage and a working implementation: https://developers.activecampaign.com/reference#update-list-status-for-contact Right now, it seems the implementation is broken. |
| # @return [Hash] a hash with information about the newly created contact | ||
| # | ||
|
|
||
| "list": 2, |
There was a problem hiding this comment.
This doesn't look like proper ruby syntax to me?
| "status": 1 | ||
|
|
||
| def update_contact_list(params) | ||
| post("contactList", contact: params) |
There was a problem hiding this comment.
According to https://developers.activecampaign.com/reference#update-list-status-for-contact it should be contact_list: params not contact: params
There was a problem hiding this comment.
- the url is invalid, should be 'contactLists'
Missing endpoint that i need for my project