Overlays reset all button#44
Merged
Merged
Conversation
Replace the three per-overlay "Reset the overlay window position" buttons with a single "Reset all overlay windows" button in the All Overlays section. Clicking it resets all three overlay window positions to 0,0 and all three overlay window scales to 100% in one action. - Reset writes the position (0,0) and scale (100%) settings for all overlays and moves any currently-open windows immediately, so it works whether or not the windows are open. - Simplify each overlay group's layout to a StackPanel now that the per-overlay scale knobs and reset buttons are gone. - Add the ResetAllOverlayWindows localization string. - Reduce overlay scale drag sensitivity (0.005 -> 0.0015) for finer control when scaling via the orange icon. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Delta Monitor overlay window (lap time + delta vs last lap + delta vs class leader) and replaces the per-overlay reset buttons with a single “Reset all overlay windows” action, including persisted scale/position reset. To support leader/last-lap comparisons, it extends timing marker tracking to expose both current and previous lap start times per car.
Changes:
- Introduce
DeltaMonitorWindow(XAML + code-behind) and wire it intoApplifecycle/ticking and the Overlays settings UI. - Add new Settings + localization keys for Delta Monitor, plus a “Reset all overlay windows” button that resets overlay scales/positions.
- Extend
TimingMarkerswithTryGetLapStartTimes()(current + previous lap start) and addDrivers.DriverInfo.CarClassIDfor class-leader identification.
Reviewed changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MarvinsAIRARefactored/Windows/DeltaMonitorWindow.xaml.cs | New overlay window logic: lap/delta computations, draggable/scalable behavior, persistence hooks |
| MarvinsAIRARefactored/Windows/DeltaMonitorWindow.xaml | New overlay UI layout + bindings to Settings/localization |
| MarvinsAIRARefactored/Pages/OverlaysPage.xaml.cs | Replace per-overlay reset handlers with a single “reset all overlays” handler; add Delta section support |
| MarvinsAIRARefactored/Pages/OverlaysPage.xaml | Add “Reset all overlay windows” button; add Delta Monitor group; remove per-overlay reset buttons |
| MarvinsAIRARefactored/DataContext/Settings.cs | Add Settings for Delta Monitor visibility/title/scale/position |
| MarvinsAIRARefactored/Components/TimingMarkers.cs | Track previous lap start time and expose lap-start times for overlays |
| MarvinsAIRARefactored/Components/Simulator.cs | Trigger Delta Monitor overlay visibility updates on connect/telemetry/disconnect paths |
| MarvinsAIRARefactored/Components/Drivers.cs | Persist CarClassID in DriverInfo for class leader selection |
| MarvinsAIRARefactored/Classes/OverlayWindowScaler.cs | Adjust scaling sensitivity for overlay drag-resize |
| MarvinsAIRARefactored/App.xaml.cs | Add DeltaMonitor window instance management, visibility control, ticking, and shutdown handling |
| MarvinsAIRARefactored/Resources/Resources.resx | Add Delta Monitor + reset-all localization keys; remove unused overlay/STT/wizard/subscription strings |
| MarvinsAIRARefactored/Resources/Resources.*.resx | Add localized Delta Monitor + reset-all keys across languages; remove unused strings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.