Add static using iterator helper
#2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
commented
Nov 1, 2021
|
|
||
| static [Symbol.asyncIterator]() { | ||
| /** @type {DisposableAggregate | undefined} */ | ||
| let res = new (this || Disposable)(); |
Owner
Author
There was a problem hiding this comment.
Not 100% refactor I guess, I fixed a previous copy-pasta mistake.
Disposable -> AsyncDisposable
Collaborator
|
I resigned as a reviewer to be realistic about my availability. I’m sure I don’t object to your moving forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a static
usingiterator helper that simplifies scoping the disposal of a single resource to afor-ofstatement.Throw when calling the
usingaggregate instance helper after the instance has been disposed of. Ensures that the resource that was attempted to be added for tracking is disposed of first.