Upgrade dependencies: caddyserver/caddy v2.10.0 + quic-go v0.54.0#316
Upgrade dependencies: caddyserver/caddy v2.10.0 + quic-go v0.54.0#316mholt merged 7 commits intomholt:masterfrom
Conversation
|
Actually all the tests pass in my IDE, but they fail here because we test against the master branch of the mainline Caddy instead of the one indicated in go.mod, and there is a change in quic-go syntax between v0.51.0 required by v2.10.0 and v0.54.0 required by the master. See also #312 (comment). |
|
If we require |
|
@vnxme what that would do is it make anyone who builds with caddy-l4 to get forced onto that version of Caddy instead of the one they actually requested (e.g. if they build |
|
@francislavoie I think that might actually be necessary in this case though since we need to use the latest quic-go version directly in this package. |
|
@francislavoie I don’t insist on bumping to a pseudo-version here and would be perfectly fine with v2.10.0. Then we would have to ignore automatic tests failures with Caddy master and users’ complaints about inability to build any commit of Caddy after quic-go upgrade with this app. Though I would rather release Caddy v2.10.1 instead to take into account the code breaking change in quic-go. |
This change is required for quic-go dependency upgrade from v0.51.0 to v0.54.0
7d08006 to
43e204c
Compare
|
I suggest we also upgrade fsnotify (required by l4remoteiplist) and things-go/go-socks5 (required by l4socks). I've rebased this PR and added these upgrades. Besides, I remember we had to remove some caddyfile related workarounds where we moved some parsing code to Caddy. Now we may merge unless there are any plans to release Caddy v2.10.1 within a few days or a week. |
|
Is there something we have not yet discussed? This PR looks good to me, though I would like to request @francislavoie and @mholt to pull the trigger. |
|
@IceCodeNew, as far as fsnotify and things-go/go-socks5 upgrades are concerned, they aren't critical at all. However, my intention was to let the users benefit from the bug fixes available in the upstreams. |
Ha, yeah, still planned, but then Go 1.25 just got released so we want to build with that, but there's some nuances we need to work out/document. I will merge this PR for now. 👍 |
|
@vnxme Thank you :) |
This PR only upgrades
caddyserver/caddyto v2.10.0 (+go mod tidy), but it is based on thel4quicmatcher fix to ensure all the tests pass. I will rebase it once we merge #315.