add support for all basic golang number types#137
add support for all basic golang number types#137grische wants to merge 1 commit intomholt:masterfrom
Conversation
cfd66e1 to
93ef0cf
Compare
this also fixes a bug where an int64 was detected for a number larger than the largest int64 number
93ef0cf to
342ae50
Compare
mholt
left a comment
There was a problem hiding this comment.
Interesting idea; I think it makes sense to use float when needed, but as for all int types other than int64, I don't think they are commonly used except when there are specific needs to use a certain number of bytes. i.e. I don't see int8 or int16 or int32 very often.
|
@mholt I also think that other types but If you are OK with #141 I will hide this feature behind a flag ( Note: the size of |
This fixes a bug where an int64 was detected for a number larger than the largest int64 number.
The number
9993372000000000000was detected as int64, despite the fact that it is outside of the limit9223372036854775807because9993372030000000000 % 1 == 0, but well within float64 limits.If the other data types are unwanted, let me know.