fix: only prepend zeros in polyphase non-streaming when mode="full"#488
Open
robrui wants to merge 1 commit into
Open
fix: only prepend zeros in polyphase non-streaming when mode="full"#488robrui wants to merge 1 commit into
robrui wants to merge 1 commit into
Conversation
The non-streaming _polyphase_input_commutate path unconditionally prepended B-1 zeros before commuting the signal. This is correct for "full" mode (first sample sits alone in the first commutated column) but incorrect for "rate" mode, where the zeros misalign the signal with decimation. Only the non-streaming path was modified. The streaming path uses separate padding logic and is unaffected. Fixes mhostetter#471
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
+ Coverage 81.81% 82.13% +0.31%
==========================================
Files 63 63
Lines 3960 4108 +148
==========================================
+ Hits 3240 3374 +134
- Misses 720 734 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks. This implements the fix in #471. I'll merge soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the non-streaming polyphase commutate path in
_polyphase_input_commutate. Whenmode="rate", B-1 zeros were incorrectly prepended before commuting, misaligning the signal with the decimation. Now fixed — zeros are only prepended inmode="full".The streaming path uses separate padding logic and is not affected by this change. All 29 multirate tests pass.