-
-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Laravel 12 Support #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@mahavishnup Could you please update the GitHub Actions CI also to include Laravel 12? Note: |
@michael-rubel, Upgraded actions/cache from v2 to v4 in workflow files. |
Now it's L12 tests and phpstan/pint is failing. |
…onsistency and test yaml updated
@michael-rubel, Now pint phpstan fix's and L12 test added |
Looks like For L12 it should be version |
@michael-rubel, carbon added |
@mahavishnup you haven't included a matrix variable for the |
@michael-rubel, I guess now everything fine? |
@mahavishnup Unfortunately not, the version must be added to each variant. 😄 |
Ohh, no can you help me on this 😢, I'm not pro at package development. |
@mahavishnup Sure, no worries! Take a look at these lines: When the test runner initializes, it takes the version per every record in the matrix, i.e. the |
Hi @michael-rubel, carbon version added. |
It looks like |
|
It seems like |
Now it can be work, I guess |
Wow, you introduced too many changes. I guess you only needed to review dependencies in P.S. You removed PHP 8.4 tests. 🥲 |
Pretty mush all test passes.