fix: Mocha version comparison fix#198
Open
97andrewvaldez wants to merge 2 commits intomichaelleeallen:masterfrom
Open
fix: Mocha version comparison fix#19897andrewvaldez wants to merge 2 commits intomichaelleeallen:masterfrom
97andrewvaldez wants to merge 2 commits intomichaelleeallen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading to Mocha v10 this string comparison broke and started setting the mocha6plus variable to false. This doesn't allow the statsCollector to later get attached to the runner and caused us some issues in our pipeline.
I added semver as a simple way to check the correct versioning. If it's preferable to make a helper method instead of adding a new npm package I can do that too.
Either way, this should fix some inconsistencies that occur when using newer versions of Mocha.