Skip to content

verify embedding is defined+define abs_sinus#2

Open
michalozeryflato wants to merge 1 commit into
devfrom
abs_sinus
Open

verify embedding is defined+define abs_sinus#2
michalozeryflato wants to merge 1 commit into
devfrom
abs_sinus

Conversation

@michalozeryflato
Copy link
Copy Markdown
Owner

@michalozeryflato michalozeryflato commented Nov 20, 2023

What does this PR do?

update T5Stack:

  1. define abs_sinus inherently in the code - so it does not need to be defined in the config
  2. check if embedding was defined and if not raise a user-friendly exception

YoelShoshan
YoelShoshan approved these changes Nov 20, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@YoelShoshan YoelShoshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YoelShoshan YoelShoshan YoelShoshan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michalozeryflato @YoelShoshan