ACCU 2018 - C++ version #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2018 22:50
…eason on one of the big files ... will investigate
…cated in C++17 ... easiest fix was to go to narrow chars
Author
|
actually ... you might want the next commit ... I left some crap in there related to wide/narrow chars ... default vs project is unicode these days. |
Owner
|
Cool. I'll try it out and see if I can make sense of it. Thank you for contributing. |
Author
|
You'll need visual studio 2017 with most of the c++ bits and Windows 10 SDK, which I think it installs, to open the solution, but the code is generic.
…Sent from my iPhone
On 12 Apr 2018, at 19:38, Michel Grootjans ***@***.***> wrote:
Cool. I'll try it out and see if I can make sense of it. Thank you for contributing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Owner
|
Could you add a readme file to explain how to get the code running ? |
Author
|
Sure
…Sent from my iPhone
On 13 Apr 2018, at 09:20, Michel Grootjans ***@***.***> wrote:
Could you add a readme file to explain how to get the code running ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Collaborator
|
Would it be a lot of work to add make scripts? So that it's possible to use it cross platform? |
Author
|
I can do ... I've messed up the parsing .. during dev I concentrated on one file ... I've tried all of them and it doesn't quite work ... so much for late night coding ... so hang fire for the moment ... I'll make a new pull request when fully working. |
Author
|
I'm just learning how to set up cmake files so I will do and that'll work for all os versions too.
…Sent from my iPhone
On 13 Apr 2018, at 12:31, Thomas Coopman ***@***.***> wrote:
Would it be a lot of work to add make scripts? So that it's possible to use it cross platform?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a C++ streaming version of app that uses JsonCpp ... just because I could.