Skip to content

Add build configuration#64

Draft
erxclau wants to merge 1 commit into
mainfrom
screenshot-config
Draft

Add build configuration#64
erxclau wants to merge 1 commit into
mainfrom
screenshot-config

Conversation

@erxclau
Copy link
Copy Markdown
Member

@erxclau erxclau commented Oct 21, 2022

What's this PR do?

Are there any relevant screenshots?

Why are we doing this? How does it help us?

How should this be manually tested?

Are there any smells or added technical debt to note?

If the configuration for screenshots is going to go in config.json, then we should probably move the COOKIE_SCREENSHOT environment variable into config.json too.

What are relevant issues or links?

Have you done the following, if applicable:

  • Performed a self-review of the code?
  • Linted code for good style and standards?
  • Added unit tests?
  • Tested manually on mobile?
  • Checked for performance implications?
  • Checked accessibility?
  • Checked for vulnerabilities with yarn audit --level=high?
  • Updated any documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant