fix(buds): polish Learnings recap rendering + share markdown styles with QA panel - #190
Merged
Merged
Conversation
…es with QA panel
The post-close Learnings tab was rendering markdown with default browser
styling — unstyled tables, thick HR lines, no paragraph spacing, weak
inline code, and weak card titles. The result looked broken next to
the Vuetify v-tables and AppCallout surfaces around it.
Extract the markdown rules into ``assets/styles/markdown-body.scss``
and apply them via the global ``.markdown-body`` class. Both this panel
and ``BUDQAPanel`` (which carried a near-duplicate block) now share one
source of truth, so test/execution plans and post-close recaps cannot
drift visually. A ``--numeric`` modifier opts tables into right-align +
tabular-nums when the generating prompt produces label/numeric columns.
Card titles ("Phase drift", "Contributors", "Retrospective") move from
``text-body-1`` to an uppercase letter-spaced eyebrow style consistent
with the design language already in use elsewhere.
Signed-off-by: Arun Rajkumar <mickyarunr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<hr>lines, no paragraph spacing, weak inline<code>. It looked broken next to the surrounding Vuetify v-tables and AppCallout surfaces.assets/styles/markdown-body.scsspartial. BothLearningsPanelandBUDQAPanel(which carried a near-duplicate block) now use the same.markdown-bodyclass, eliminating future visual drift between test/execution plans and post-close recaps..markdown-body--numericmodifier opts tables into right-alignedtabular-numsfor the 2nd+ columns — used by the Phase Breakdown table whose generating prompt always emits label/numeric columns.text-body-1to an uppercase letter-spaced eyebrow style, matching design language already in use.Before / After
Verified locally against a real prod retrospective (BUD-008 closed, recap generated by the Learning Agent) — phase-drift table, contributors, and rendered retrospective now share the same visual language. Markdown tables get the v-table look, inline code reads cleanly, paragraphs breathe.
Test plan
test_plan_md/qa_execution_plan_md— QA panel still looks correct (same shared class)vue-tsc --noEmitclean