Propagate run context through agent streams - #4753
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves agent streaming behavior by threading ai.RunInfo through the agentImpl.Stream call path so downstream providers can observe run metadata, and by avoiding work when the caller’s context is already canceled.
Changes:
- Attach
ai.RunInfo(RunID/ParentID/Agent) to the context used for provider streaming calls. - Short-circuit
agentImpl.Streamearly whenctxis already canceled, and add tests asserting provider/memory are skipped on pre-canceled contexts. - Extend streaming tests to assert providers receive
RunInfo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agent/agent.go | Adds context cancellation short-circuiting and injects ai.RunInfo into provider streaming calls. |
| agent/stream_test.go | Adds assertions that RunInfo reaches the provider stream and that canceled contexts skip provider/memory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
237
to
+246
| toolList, err := a.discoverTools() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("discover tools: %w", err) | ||
| } | ||
| runID := uuid.New().String() | ||
| ctx = ai.WithRunInfo(ctx, ai.RunInfo{ | ||
| RunID: runID, | ||
| ParentID: a.parentRunID, | ||
| Agent: a.opts.Name, | ||
| }) |
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates agent run context into provider streaming calls and skips provider/memory work when a stream is already canceled.
Testing:
Closes #4750
Closes #4752