Skip to content

Commit fc99d07

Browse files
authored
Merge pull request #1886 from microbiomedata/issue-1885-analysis-tab-copy-bug
Prevent first row from always being removed in submission tab data merge
2 parents 68aff6a + 45f51d8 commit fc99d07

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

web/src/views/SubmissionPortal/HarmonizerView.vue

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ export default defineComponent({
311311
const rowId = row[SCHEMA_ID];
312312
return environmentSlots.some((environmentSlot) => {
313313
const environmentRow = nextData[environmentSlot as string]?.findIndex((r) => r[SCHEMA_ID] === rowId);
314-
return environmentRow && environmentRow >= 0;
314+
return environmentRow !== undefined && environmentRow >= 0;
315315
});
316316
});
317317
}
@@ -973,15 +973,14 @@ export default defineComponent({
973973
v-bind="props"
974974
>
975975
<v-tab>
976+
{{ HARMONIZER_TEMPLATES[templateKey]?.displayName }}
976977
<v-badge
977978
:content="validationTotalCounts[templateKey] || '!'"
978-
floating
979-
location="top right"
979+
max="99"
980+
inline
980981
:model-value="(validationTotalCounts[templateKey] && validationTotalCounts[templateKey] > 0) || !tabsValidated[templateKey]"
981982
:color="(validationTotalCounts[templateKey] && validationTotalCounts[templateKey] > 0) ? 'error' : 'warning'"
982-
>
983-
{{ HARMONIZER_TEMPLATES[templateKey]?.displayName }}
984-
</v-badge>
983+
/>
985984
</v-tab>
986985
</div>
987986
</template>

0 commit comments

Comments
 (0)