Evaluate our current design patterns

[hesspnnl]

Evaluate the current design of NMDCMetadataGenerator and NMDCWorkflowMetadataGenerator classes.

• Create better rules for hwne a funciton should go in one vs the other.
• Does the name NMDCWorkflowMetadataGenerator make sense with the new addition of material processing steps? What name could be better used and encapsulate more changes without the need for alterations in the future?
• Do we need the use of self.attribute name in fucntions in these class? I feel they add confusion adn should be passed in as parameters.

[kheal]

"Do we need the use of self.attribute name in functions in these class? I feel they add confusion and should be passed in as parameters." Agreed!