Move to ESLint 10 and @microbit/eslint-config 0.2.1 - #26
Merged
Conversation
Pin the React version the rules key off. eslint-react follows whatever React resolves in the project, which is 19, but we publish for React >= 17.0.2: without the pin it flags our forwardRef components, our Context.Provider and our useContext, none of which our consumers on 17 or 18 can drop. That leaves one real finding the old plugin never reported: the frame passed key after the prop spread, which deoptimises the automatic JSX runtime. Key first. Nothing changes semantically, as a props object never carries key. npm cannot resolve this bump in one step. The lockfile pins the old shared config with its eslint ^9.7 peer and npm tries to reconcile that rather than replace it, failing with a circular ERESOLVE. Uninstall eslint and @microbit/eslint-config first, then install the new pair.
Deploying makecode-embed with
|
| Latest commit: |
6111749
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5bd9383.makecode-embed.pages.dev |
| Branch Preview URL: | https://eslint-10.makecode-embed.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the React version the rules key off. eslint-react follows whatever React resolves in the project, which is 19, but we publish for React
That leaves one real finding the old plugin never reported: the frame passed key after the prop spread, which deoptimises the automatic JSX runtime. Key first. Nothing changes semantically, as a props object never carries key.
npm cannot resolve this bump in one step. The lockfile pins the old shared config with its eslint ^9.7 peer and npm tries to reconcile that rather than replace it, failing with a circular ERESOLVE. Uninstall eslint and @microbit/eslint-config first, then install the new pair.