Drop unused production dependencies - #4
Merged
Conversation
typedoc is only used by the docs script, but as a runtime dependency its typescript peer range (capped at 5.8.x for typedoc 0.27) constrains consumers' typescript version: classroom's Renovate typescript 5.9 bump produced a lockfile npm ci rejects. react/react-dom were listed in both dependencies and peerDependencies, forcing react on consumers of the vanilla entry point. They are now devDependencies (for Storybook) alongside the existing peer ranges.
importHelpers is not enabled, so tsc inlines its helpers and nothing imports tslib.
They were compiled into dist despite not being exported, dragging their base64-js import in as a runtime dependency; it is now dev-only. The build uses a new tsconfig.build.json while tsconfig.json still covers everything for the editor and the new typecheck script in ci, so the stories remain typechecked (Storybook's own build only transpiles).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.